Fraction output v2#593
Conversation
# Conflicts: # app/src/main/java/com/darkempire78/opencalculator/MyPreferences.kt # app/src/main/java/com/darkempire78/opencalculator/activities/MainActivity.kt
# Conflicts: # app/src/main/java/com/darkempire78/opencalculator/MyPreferences.kt # app/src/main/java/com/darkempire78/opencalculator/activities/MainActivity.kt
|
The PR looks very good, i just see that:
|
|
@bmg1919 is it intentional to remove the "live calculation" ? |
Not originally no. I'm correcting it now. |
|
I found my error and found one or two others in the fraction function. At the present time, it only converts the final result to a fraction on pressing '='. On equals, it displays both decimal and fraction answers. |
|
I've now updated it so that fractions show in the live result. '=' now shows decimal value on top and fraction below. I kind of like having both results on screen but can attempt adjustment. |
any news ? |
|
I've actually not looked at it for a bit as I've had other responsibilities to deal with. I seem to recall being somewhat happy with it. Was there more to be done I may have forgotten? |
|
Idk why, but nothing seems to work right now... I was going to merge it. Even the live calc is not working again |
|
I will investigate. I have a combined build running on my phone at the moment, and the live calculation appears to be working whether the fraction output is on or off. |
|
I tested on APIs 25 and 37 and am still unable to reproduce any failures. I merged the couple of commits from main, ran "clean project", and rebuilt main and fraction-output-v2; both appear to behave similarly in the live calculations. I did the same with my combined branch, and they all seem to behave the same. Perhaps the merge was enough? They didn't appear to be anything that would cause a conflict, but I've been wrong before. |
2 participants
New PR to replace #535