Deprecate middleware auth gating across Next.js reference and guides - #3405
Closed
jacekradko wants to merge 4 commits into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jacekradko
force-pushed
the
jacek/deprecate-createroutematcher-nextjs
branch
from
June 5, 2026 03:06
f02d2a7 to
5fad417
Compare
Wraps the auth-gating sections of the Next.js clerkMiddleware reference with the deprecation notice (keeping anchors and clerkMiddleware config intact), redirects token-type gating to auth({ acceptsToken }) at the route, and points readers to resource-level protection. Updates the guides that taught the pattern: basic-rbac now leads with page-level checks, session-tasks elevates <RedirectToTasks />, geo-blocking and satellite-domains keep their middleware but drop the auth tail, the custom sign-in/up steps are framed as legacy, CSP examples drop the irrelevant auth gating, and the MCP guide no longer special-cases .well-known. All surviving createRouteMatcher examples use the newline-safe :path* form instead of (.*).
The newline-bypass mechanism for (.*) maps to an unpublished advisory (still embargoed), so the reference page should not describe it yet. Keep the neutral :path* recommendation; the security framing returns with the deprecation track once the CVE is public.
…n (nextjs) Onboarding WARNING: drop the embargoed 'can be bypassed' assertion, keep the not-a-security-boundary point via re-render + separate-route-model framing. clerk-middleware NOTE: add a non-security reason for the :path* swap so it can't be paired with bypass prose to reconstruct the unpublished fix.
jacekradko
force-pushed
the
jacek/deprecate-createroutematcher-nextjs
branch
from
June 5, 2026 03:22
5fad417 to
5701fe8
Compare
basic-rbac: await the async checkRole() in setRole and AdminDashboard (a negated Promise is always falsy, so the guard never fired), and add the missing admin check to removeRole. The page argues resource-level protection hardest; its sample guards must actually run. geo-blocking, satellite-domains: give the 'protect at the resource' pointers a one-line, embargo-safe why (keeps the check in sync with your routes) so the de-gated examples don't read as arbitrary churn.
Contributor
Author
|
Heads up: this PR is part of the #3426 carries a reframed, positive-recommendation version of the shared Keeping |
Contributor
Author
|
Superseded by #3426, now the canonical Next.js |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #3404. Applies the deprecation across the Next.js reference and the guides that taught middleware gating.
The reference page is kept-but-wrapped: each auth-gating section keeps its existing anchor but gains the deprecation notice, token-type gating now points to
auth({ acceptsToken })at the route, and the Combine-Middleware example loses itsauth.protect()line. In the guides,basic-rbacnow leads with the page-level check,session-taskselevates<RedirectToTasks />,geo-blockingandsatellite-domainskeep their middleware but drop the auth tail, the custom sign-in/up steps are framed as legacy, the CSP examples drop the auth gating that was never relevant to CSP, and the MCP guide stops special-casing.well-known.Load-bearing bit to scrutinize: every surviving
createRouteMatcherexample moves from/foo(.*)to/foo/:path*. The(.*)form misses encoded newlines (a bypass) and over-matches/foobar;/:path*fixes both. Verified against the SDK's path-to-regexp.