fix(deploy): use Frontend API URL for OAuth redirect URI in walkthrough#335
fix(deploy): use Frontend API URL for OAuth redirect URI in walkthrough#335Railly wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 5eac92d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The OAuth walkthrough printed https://accounts.{domain}/v1/oauth_callback, but /v1/oauth_callback is served by the Frontend API (clerk.{domain}), not the Account Portal. Users pasting the printed value into their provider console hit redirect_uri_mismatch. Thread frontend_api_url from the PLAPI domain response through DeployOperationState and LiveDeploySnapshot into showOAuthWalkthrough, falling back to https://clerk.{domain} if absent.
61640b5 to
31baaf9
Compare
|
Warning Review limit reached
More reviews will be available in 55 minutes and 12 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more credits in the billing tab to continue. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
📝 WalkthroughWalkthroughThis PR updates the Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
c1135f5 to
5eac92d
Compare
Problem
The OAuth walkthrough in
clerk deployprintshttps://accounts.{domain}/v1/oauth_callbackas the redirect URI. That endpoint lives on the Frontend API (clerk.{domain}), not the Account Portal, so pasting the printed value into a provider console causesredirect_uri_mismatch. Affects every provider walkthrough since #260.Fix
PLAPI already returns the correct value as
frontend_api_urlon the domain object; it was being dropped. Thread it through deploy state (new-deploy and resume paths) intoshowOAuthWalkthrough, with ahttps://clerk.{domain}fallback since TS types do not validate runtime JSON.Tests
frontend_api_urlproves the value is threaded, not string-built from the domainaccounts.onebun test,typecheck,lint,format:checkpass