-
Notifications
You must be signed in to change notification settings - Fork 461
fix(expo): Resolve Android native modules optionally #9203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+63
−4
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@clerk/expo': patch | ||
| --- | ||
|
|
||
| Fix a crash on Android in Expo Go where rendering `<ClerkProvider>` failed with `Cannot find native module 'ClerkExpo'`, even for JavaScript-only flows that use no native components. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| import { beforeEach, describe, expect, test, vi } from 'vitest'; | ||
|
|
||
| const mocks = vi.hoisted(() => ({ | ||
| available: {} as Record<string, unknown>, | ||
| })); | ||
|
|
||
| // Only returns a module when one is registered under the exact name requested. | ||
| vi.mock('expo', () => ({ | ||
| requireNativeModule: (name: string) => { | ||
| const nativeModule = mocks.available[name]; | ||
| if (!nativeModule) { | ||
| throw new Error(`Cannot find native module '${name}'`); | ||
| } | ||
| return nativeModule; | ||
| }, | ||
| requireOptionalNativeModule: (name: string) => mocks.available[name] ?? null, | ||
| })); | ||
|
|
||
| // Path is a variable because TypeScript cannot resolve the platform suffix in a | ||
| // dynamic import. | ||
| const importSpec = async (path: string) => (await import(path)).default; | ||
|
|
||
| const importSpecs = async () => ({ | ||
| clerkExpo: await importSpec('../NativeClerkModule.android'), | ||
| googleSignIn: await importSpec('../NativeClerkGoogleSignIn.android'), | ||
| }); | ||
|
|
||
| describe('android native module specs', () => { | ||
| beforeEach(() => { | ||
| vi.resetModules(); | ||
| mocks.available = {}; | ||
| }); | ||
|
|
||
| test('resolve to null instead of throwing when not compiled in (Expo Go)', async () => { | ||
| const { clerkExpo, googleSignIn } = await importSpecs(); | ||
|
|
||
| expect(clerkExpo).toBeNull(); | ||
| expect(googleSignIn).toBeNull(); | ||
| }); | ||
|
|
||
| test('resolve the module registered under the expected name (development build)', async () => { | ||
| const clerkExpoModule = { configure: vi.fn() }; | ||
| const googleSignInModule = { signIn: vi.fn() }; | ||
| mocks.available = { ClerkExpo: clerkExpoModule, ClerkGoogleSignIn: googleSignInModule }; | ||
|
|
||
| const { clerkExpo, googleSignIn } = await importSpecs(); | ||
|
|
||
| expect(clerkExpo).toBe(clerkExpoModule); | ||
| expect(googleSignIn).toBe(googleSignInModule); | ||
| }); | ||
| }); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.