Optimize block iteration to prevent memory leaks#119
Open
LetMePractice wants to merge 1 commit intoclickcrystals-development:mainfrom
Open
Optimize block iteration to prevent memory leaks#119LetMePractice wants to merge 1 commit intoclickcrystals-development:mainfrom
LetMePractice wants to merge 1 commit intoclickcrystals-development:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Reworked block iteration to stop allocating new
BlockPosobjects inside hot loops.The old implementation was creating a new
BlockPosper iteration. Under heavy scripting this adds up to millions of allocations over time and eventually causes GC pressure and long-session instability.Changes
PlayerUtils.boxIterator()now usesBlockPos.MutablerunOnNearestBlock()/getNearestBlock()switched from cubic scan to spiral search and reuse a mutable positionEntityUtils.runOnNearestBlock()updated the same wayRaytracer.trace()reuses a singleBlockPos.MutableConditionalBlockInFovrewritten to use a 3x3 raycast grid instead of block iterationImpact
Related issues
Fixes long-session black screen when
block_in_range/block_in_fovare used heavily in scripts.Checklist: