Resolve upstream main conflicts for server-side params#1
Draft
youngsofun wants to merge 5 commits into
Draft
Conversation
* python: add local embedded connection support * update * fix: add license header to local.py * style: apply ruff format to python binding files * fix: token-aware named params, positional count check, relative DSN path * docs: fix maturin develop command in README * docs(python): update README with complete local embedded API documentation * docs: fix maturin develop command, use '-- --uv' instead of '--uv' * docs: remove --uv flag from maturin develop command * fix: add pyarrow to local extra dependencies
…ram-binding # Conflicts: # core/src/request.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This helps unblock databendlabs#762 by merging the latest upstream
mainintofeat/server-side-param-bindingand resolving the conflict with the newarrow_result_version_maxrequest field.Changes:
/v1/queryrequest fields:paramsandarrow_result_version_max.with_params()andwith_arrow()builders and add serialization coverage for using both together.Value::to_json_value()for the newerGeoValuegeometry/geography representation from upstream main.Verification run:
cargo test -p databend-client requestcargo test -p databend-driver paramscargo test -p databend-driver placeholdercargo test -p databend-driver-core to_sql_stringcargo fmt --checkruff format .frombindings/pythoncargo test -p databend-pythoncargo test -p databend-driver-coreAlso attempted:
cargo test -p databend-clientfailed only instage::insert_with_stage_presignedbecause the local test Databend returnedstorage doesn't support presign operation.cargo test -p databend-driverfailed only inload::load_csv_with_presignandload::stream_load_with_presignfor the same local presign storage limitation.