Skip to content

Resolve upstream main conflicts for server-side params#1

Draft
youngsofun wants to merge 5 commits into
cliftonc:feat/server-side-param-bindingfrom
youngsofun:pr-762-server-side-param-binding-fix
Draft

Resolve upstream main conflicts for server-side params#1
youngsofun wants to merge 5 commits into
cliftonc:feat/server-side-param-bindingfrom
youngsofun:pr-762-server-side-param-binding-fix

Conversation

@youngsofun
Copy link
Copy Markdown

This helps unblock databendlabs#762 by merging the latest upstream main into feat/server-side-param-binding and resolving the conflict with the new arrow_result_version_max request field.

Changes:

  • Keep both /v1/query request fields: params and arrow_result_version_max.
  • Preserve with_params() and with_arrow() builders and add serialization coverage for using both together.
  • Adapt Value::to_json_value() for the newer GeoValue geometry/geography representation from upstream main.

Verification run:

  • cargo test -p databend-client request
  • cargo test -p databend-driver params
  • cargo test -p databend-driver placeholder
  • cargo test -p databend-driver-core to_sql_string
  • cargo fmt --check
  • ruff format . from bindings/python
  • cargo test -p databend-python
  • cargo test -p databend-driver-core

Also attempted:

  • cargo test -p databend-client failed only in stage::insert_with_stage_presigned because the local test Databend returned storage doesn't support presign operation.
  • cargo test -p databend-driver failed only in load::load_csv_with_presign and load::stream_load_with_presign for the same local presign storage limitation.

youngsofun and others added 5 commits April 22, 2026 00:13
* python: add local embedded connection support

* update

* fix: add license header to local.py

* style: apply ruff format to python binding files

* fix: token-aware named params, positional count check, relative DSN path

* docs: fix maturin develop command in README

* docs(python): update README with complete local embedded API documentation

* docs: fix maturin develop command, use '-- --uv' instead of '--uv'

* docs: remove --uv flag from maturin develop command

* fix: add pyarrow to local extra dependencies
…ram-binding

# Conflicts:
#	core/src/request.rs
@youngsofun youngsofun marked this pull request as draft May 11, 2026 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants