fix: remove string-based run_model API from C runtime + update main.c to use runModelWithBuffers
#766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…run_model` + add `runModel`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #302
@ToddFincannonEI: See issue for details. I don't know if you are relying on the string-based
run_modelAPI for EPS, but if you are, the changes tomain.cdemonstrate how to get the same behavior as before, so hopefully you could retrofit your code in a similar way. But let me know if any of this causes big problems for you.I'm going to submit another PR shortly for changes that overlap slightly (adding parameters to
runModelWithBuffersto support the "override constants" feature), so I suggest reviewing this one first. Once you approve both, I will merge this one first and will update the other to make therunModelWithBufferschanges consistent.AI disclosure: I used Claude Code (Opus) to implement the first round of changes according to my detailed specification (recorded in the issue). I reviewed and edited the changes pretty heavily and rewrote the
runModel[WithBuffers]docs for clarity.