Add sw-precache, register serviceWorker#10
Open
matthiaskern wants to merge 3 commits intoclintonwoo:masterfrom
Open
Add sw-precache, register serviceWorker#10matthiaskern wants to merge 3 commits intoclintonwoo:masterfrom
matthiaskern wants to merge 3 commits intoclintonwoo:masterfrom
Conversation
matthiaskern
commented
Oct 3, 2017
| new SWPrecacheWebpackPlugin({ | ||
| minify: true, | ||
| verbose: true, | ||
| staticFileGlobsIgnorePatterns: [/\.next\//], |
Contributor
Author
There was a problem hiding this comment.
this is to ignore all static files served by next
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looking at #6, I decided to go ahead and try sw-precache.
The plugin doesn't actually cache anything while webpack in compile-time, but is caching runtime and returning cached assets when the app is offline.
The service worker get's registered only in the index route, but should consider if it would be better to do globally.
I also added
NODE_ENV=productionflag for thebuildstep, as otherwise the next app was not build with production mode for me locally. I tested this withnpm startafterwards, and it includedwebpack-hmrrequests.