Open
Conversation
a978956 to
0f6d975
Compare
0f6d975 to
5f98d4e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, @clintonwoo,
Thanks for your awesome React app🎉
This app has two errors on executing
npm test. I fixed them. If you like these changes, please merge this Pull Request😀1. Jest setting is missing
I ran
npm testand got the following message.I think that Jest settings are missing. I added
"testEnvironment": "node"parameter topackage.json.2. fail to initialize Apollo for testing
After setting
testEnvironment, I runnpm testagain and got the following error message.this.props.serverState.apollo.dataisn't initialized.I'm not sure is this a coding mistake? I switched to
{}fromthis.props.serverState.apollo.data. I don't know if this chage is a correct fix.finally
After fixing them, all test passed!