Skip to content

feat: adding query recommended movies and view profile recommend a slop#59

Open
Dbishop15 wants to merge 1 commit into
mainfrom
feature/query-recommended-movies
Open

feat: adding query recommended movies and view profile recommend a slop#59
Dbishop15 wants to merge 1 commit into
mainfrom
feature/query-recommended-movies

Conversation

@Dbishop15

Copy link
Copy Markdown
Collaborator

Describe your changes

  • Add movie recommendations by creating queries that are based on the user's preferences. It recommends a list of slops based on user preferences for the logged-in user in the dropdown list.
  • Fetch recommended slopes for the logged-in user using the slope recommendation query and display them in a grid similar to the browse-movies page.

Issue ticket number and link

SLOP-2: Recommended Movies
https://tripleten-apiary.atlassian.net/browse/SLOP-2
SLOP-6: View: Profile - Recommend-A-Slop
https://tripleten-apiary.atlassian.net/browse/SLOP-6

Checklist before requesting a review

  • [x ] I have performed a self-review of my code
  • If there are changes to components, I have added / updated automated tests
  • I have made any necessary updates to Storybook to accompany these changes
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [x ] My changes generate no new warnings

Comment thread src/graphql/get-users.js
}
`;

export const GET_USERS_WATCHLIST = gql`

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is great but, it gets all user watchlists, not just the current user's like the query above this.

Comment thread src/graphql/get-users.js
`;

export const GET_USERS_WATCHLIST = gql`
query GetUsersWatchlist {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This query should get a list of recommended movies based off the current user's preferences rather than the current user's watchlist and watched slops. The wishlist and watched are a part of the me goblin profile page. The page and logic for user preference currently does not exist.

import { ProfileHorizontalMenu } from "./profile-horizontal-menu";
import { ProfileSidebar } from "./profile-sidebar";

export const ProfileRecommendedRoute = () => {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, but I believe that something was misinterpreted or miscommunicated. This logic seems to be more for the me goblin page rather than the recommended page. This code might only have to be slightly refactored for recommending slops. It might be blocked until the user preferences have been created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants