Skip to content

Conversation

@Shubham8287
Copy link
Contributor

@Shubham8287 Shubham8287 commented Jan 22, 2026

Description of Changes

Patch:

  1. crates/lib/src/db/raw_def/v10.rs - a definition as per https://github.com/clockworklabs/SpacetimeDBPrivate/issues/2412.
  2. Refactors RawModuleDefV9 validation code to dedup some of the core validation logic, No functionality should change there.
  3. Validation logic for new RawModuleDefV10.
  4. Modify crates::schema::def::ModuleDef :
    • To include raw_module_def_version
    • visibility field to existing RedcuerDef and ProcedureDef
  5. It deprecates RLS in favour of Views, If anyoine feel otherwise, let me know.

Lot of code is duplicated from RawModuleDefV9 includng tests.

API and ABI breaking changes

NA, RawModuleDefV10 is not yet exported by modules.

Expected complexity level and risk

3? close analyses of structure is important to ensure future extensibility.

Testing

For code motion in RawModuleDefV9 validation: Existing unit tests seems to cover any functionality change.
For RawModuleDefV10: V9 test has been repeated with more asserts to check on visibility

Copy link
Contributor

@gefjon gefjon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked at your validation logic yet, but I assume it's reasonably straightforward. The raw def format itself looks great, excellent work.

@Shubham8287 Shubham8287 requested a review from gefjon January 27, 2026 15:56
@Shubham8287 Shubham8287 removed the request for review from joshua-spacetime January 27, 2026 18:42
@Shubham8287 Shubham8287 enabled auto-merge January 27, 2026 18:43
@Shubham8287 Shubham8287 added this pull request to the merge queue Jan 27, 2026
@gefjon gefjon removed this pull request from the merge queue due to a manual request Jan 27, 2026
@Shubham8287 Shubham8287 enabled auto-merge January 28, 2026 03:24
@Shubham8287 Shubham8287 force-pushed the shub/raw-defination branch 2 times, most recently from 62e46ad to 860d600 Compare January 28, 2026 11:46
@Shubham8287 Shubham8287 added this pull request to the merge queue Jan 28, 2026
Merged via the queue into master with commit 0b904ad Jan 28, 2026
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants