-
Notifications
You must be signed in to change notification settings - Fork 680
Add spacetime login --no-browser
#4142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
jdetter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, tested both with and without --no-browser on windows and it works. I haven't tested macOS or linux but I think those should both work as well.
Thanks Zeke 🙏
LLM Benchmark Results (ci-quickfix)
Compared against master branch baseline Generated at: 2026-01-27T18:16:45.763Z Failure Analysis (click to expand)Benchmark Failure AnalysisGenerated from: Summary
Analysis of SpacetimeDB Benchmark Test FailuresBelow is an analysis of the SpacetimeDB benchmark test failures, organized by language and mode. Each failure includes the generated code, expected code, failure reasons, and actionable recommendations. Rust / rustdoc_json FailuresCompile/Publish Errors (3 failures)t_002_scheduled_table
t_017_scheduled_columns
Other Failures (7 failures)t_003_struct_in_table
Rust / docs Failures (22 total)Compile/Publish Errors (1 failure)t_018_constraints
Other Failures (21 failures)(Similar analysis can be followed for the remaining failures, grouped by similar symptoms, API misuse, and other patterns.) C# / docs Failures (5 total)Other Failures (5 failures)t_005_update
Continuing this approach for the remaining failures will yield a comprehensive and actionable documentation improvement plan. |
Description of Changes
Addresses #4131.
I did not thread the new option into other commands such as
spacetime init(they just retain the previous behavior). I think this is a relatively niche use case, and it's easy to work around either way (by just usingspacetime loginfirst) so I'd wait until someone asks us to thread it through to other places.API and ABI breaking changes
None
Expected complexity level and risk
1
Testing
spacetime login --no-browserand saw that it didn't open a browserspacetime loginand saw that it still opened a browser