Draft
Conversation
Signed-off-by: Vicente Zepeda Mas <vzepedam@redhat.com>
chentex
force-pushed
the
fix-benchmark-names
branch
from
2c12561 to
a69dc1d
Compare
Fixing systemd analyze image for arm64 Signed-off-by: Vicente Zepeda Mas <vzepedam@redhat.com>
Collaborator
|
Don't you need to change |
Member
Author
Good catch! |
Signed-off-by: Vicente Zepeda Mas <vzepedam@redhat.com>
Codecov Report
@@ Coverage Diff @@
## master #398 +/- ##
=======================================
Coverage 39.35% 39.35%
=======================================
Files 15 15
Lines 869 869
=======================================
Hits 342 342
Misses 527 527
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Collaborator
|
Results for SNAFU CI Test
|
learnitall
reviewed
Nov 30, 2021
Contributor
learnitall
left a comment
learnitall
left a comment
There was a problem hiding this comment.
Looks great! Can't find anything missing, but I'll try to do a more thorough double check with grep tomorrow.
| @@ -1,11 +1,12 @@ | |||
| FROM registry.access.redhat.com/ubi8:latest | |||
|
|
|||
| RUN dnf install -y --nodocs git python3-pip && dnf clean all | |||
Contributor
There was a problem hiding this comment.
Was this change intentional here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Inconsistencies on naming have been having negative effects on our automation on image building.
Fixes
#347