Fix issue #5: Refactor default.nix into modular files#14
Open
MattiasKockum wants to merge 5 commits into
Open
Conversation
Split USB and netboot installers into a new 'installers' directory. Add myself as a contributor.
Move 'terminals' and 'toplevelRegistry' into a new 'registry' directory.
Move ci code and shell into 'dev' directory.
Move defaultSystem into 'lib' directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5
What changed?
default.nixinto:installers/default.nix
installers/netboot.nix
installers/usb.nix
registry/default.nix
dev/ci.nix
dev/default.nix
dev/shell.nix
lib/default-system.nix
Motivation
This refactor prepares the ground for working on features without cluttering
default.nix.How to test?
nix-instantiate -A usb-installerproduces the same hash. Same goes for 'toplevelRegistry'.nix-instantiate -A net-installerproduces the same error before and after (that could lead to the oppening of a separate issue)nix-instantiate -A shellproduces a different hash but this is because ci usessrc = ../.so any change in the code base actually changes the hash here.