Sécurix for qemu / kvm#173
Merged
Merged
Conversation
| security.tpm2.enable = lib.mkForce false; | ||
|
|
||
| # Pas d'agent SSH TPM pour la VM (TODO) | ||
| securix.ssh.tpm-agent.hostKeys = lib.mkForce false; |
Contributor
There was a problem hiding this comment.
Pas besoin de le désactiver manuellement, il faut laisser ces modules s'auto désactiver.
| services.qemuGuest.enable = true; | ||
|
|
||
| # Pas de TPM2 émulé par défaut (TODO) | ||
| security.tpm2.enable = lib.mkForce false; |
| # This is an intermediate priority override, normal override is 100, mkDefault is 1000. We take the middle here. | ||
| networking.hostName = lib.mkOverride 500 "m${toString targetSystem.config.securix.self.inventoryId}"; | ||
| system.nixos.tags = [ "m${toString targetSystem.config.securix.self.inventoryId}" ]; | ||
| networking.hostName = lib.mkOverride 500 "m${toString targetSystem.config.securix.self.machine.inventoryId}"; |
Contributor
There was a problem hiding this comment.
Merci de séparer bien les commits pour adresser les deprecations.
rlahfa-dinum
requested changes
May 28, 2026
rlahfa-dinum
left a comment
Contributor
There was a problem hiding this comment.
Ça a l'air très raisonnable, pourriez-vous appliquer les conventions de commit du projet? Merci!
5e1b01b to
3769f3e
Compare
Contributor
Author
|
Merci pour la review @rlahfa-dinum. Modifications effectuées :
Le fix des options dépréciées n'est peut-être pas pertinent dans cette PR... dis-moi. VM testée avec les corrections. |
rlahfa-dinum
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sécurix in a QEMU/KVM virtual machine, for testing.