Fix split email in self module#175
Open
darkone-linux wants to merge 1 commit into
Open
Conversation
rlahfa-dinum
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix addresses two issues:
splitString "."on the email could incorrectly capture the@.john.doe@domain.tld->john,doe@domainelemAtwas most likely reversed.To test quickly:
It should normally produce:
NB: It might make sense to move this kind of processing into a dedicated library, using testable helper functions. That would make the algorithm more robust and allow handling additional cases, for example email addresses that do not follow the "firstname.lastname..." pattern.