modules/tools/browsers: init#71
Draft
rlahfa-dinum wants to merge 1 commit into
Draft
Conversation
This rework the abstraction module for Firefox into a generic abstraction for both major browsers: Chromium and Firefox. This enables developers to let user choose between Firefox and Chromium and configure them uniformly. Obviously, abstracting all options is impossible, so a developer should always consider using the fine-grained API of a browser if needed. Signed-off-by: Ryan Lahfa <ryan.lahfa.ext@numerique.gouv.fr>
jdauphant-dinum
left a comment
jdauphant-dinum
left a comment
Contributor
There was a problem hiding this comment.
I will have see most config "mkDefault" configuration, and we setup only commun option that will work for both browser.
If the user want to improve the configuration, he can use directly the firefox ou chromium option.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rework the abstraction module for Firefox into a generic abstraction for both major browsers: Chromium and Firefox.
This enables developers to let user choose between Firefox and Chromium and configure them uniformly.
Obviously, abstracting all options is impossible, so a developer should always consider using the fine-grained API of a browser if needed.
This PR is not finished yet, it's open to collect early feedback.
TODO: