Skip to content

fix: slug/path uniqueness is problematic and not inherently useful#53

Merged
zjrgov merged 2 commits intomainfrom
feat/zjr-rsrc-uq
Feb 27, 2026
Merged

fix: slug/path uniqueness is problematic and not inherently useful#53
zjrgov merged 2 commits intomainfrom
feat/zjr-rsrc-uq

Conversation

@zjrgov
Copy link
Contributor

@zjrgov zjrgov commented Feb 26, 2026

Changes proposed in this pull request:

  • Slug can be a problematic unique constraint and is not as important as path
  • …but path is still problematic
  • Disambiguating would rely on the resource ID and that's already a field on the nodes anyway

E.g., apps get deleted and re-created with the same name; they aren't
literally the same anymore, but I don't have a compelling reason to
think the path should change.

Security considerations

None, swapping a unique constraint

@zjrgov zjrgov requested review from a team as code owners February 26, 2026 21:41
rahearn
rahearn previously approved these changes Feb 26, 2026
E.g., apps get deleted and re-created with the same name; they aren't
literally the same anymore, but I don't have a compelling reason to
think the path should change.
@zjrgov zjrgov changed the title fix: path is a much more useful unique constraint on resource_nodes fix: slug/path uniqueness is problematic and not inherently useful Feb 27, 2026
@zjrgov zjrgov requested a review from rahearn February 27, 2026 14:39
@zjrgov zjrgov merged commit d58798b into main Feb 27, 2026
6 checks passed
@zjrgov zjrgov deleted the feat/zjr-rsrc-uq branch February 27, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants