Skip to content

Fixes for cost estimator script #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markdboyd merged 1 commit into from
Feb 23, 2026
Merged

Fixes for cost estimator script #381

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions cost-estimator/estimate-costs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,17 +36,11 @@ def get_instance_plan_name(self, instance_guid):
return cf_data.get("included", "N/A")["service_plans"][0]["name"]

def get_service_plan_name(self, instance_guid):
# FIXME: Maybe we shouldn't trust the plan name in the tag, but it's faster
service_plan_name = "Not_Found"
try:
service_plan_name = [
tag["Value"] for tag in self.tags if tag["Key"] == "Service plan name"
][0]
service_plan_name = self.get_instance_plan_name(instance_guid)
except:
try:
service_plan_name = self.get_instance_plan_name(instance_guid)
except:
service_plan_name = "Not_Found"
service_plan_name = "Not_Found"
return service_plan_name


Expand Down Expand Up @@ -292,9 +286,15 @@ def get_aws_instances(self, client, resource_type):

def get_rds_instances(self, client):
response = self.get_aws_instances(client, "rds")
rds_instance_guids = []
for resource in response["ResourceTagMappingList"]:
rds = Rds(resource["ResourceARN"], resource["Tags"])
self.rds_instances.append(rds)
# replica databases will appear twice in the list of
# tagged resources, but they should only be tracked once
# for cost purposes
if rds.instance_guid not in rds_instance_guids:
self.rds_instances.append(rds)
rds_instance_guids.append(rds.instance_guid)

def get_redis_instances(self, client):
response = self.get_aws_instances(client, "redis")
Expand Down Expand Up @@ -357,6 +357,8 @@ def report_rds(self, tags_client, reporter):
self.get_rds_instances(tags_client)
for rds in self.rds_instances:
rds.get_db_instance(rds_client)
if "replica" in rds.service_plan_name:
print(rds.instance_guid)
self.rds_instance_plans[rds.service_plan_name] += 1
self.rds_allocation += rds.allocated_storage

Expand Down