docs: fix CRD values descriptions and remove unsed dsc.global.values#1041
Open
benji78 wants to merge 1 commit into
Open
docs: fix CRD values descriptions and remove unsed dsc.global.values#1041benji78 wants to merge 1 commit into
benji78 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quel est le comportement actuel ?
La documentation des champs
valuesdans la CRD n'est plus à jour et est ambiguë ou incorrecte sur les emplacements utilisés par les charts/roles. Elle ne distingue pas clairement la différence entre les valeurs pour la CR GitLab vs le chart de l’opérateur. La CRD expose aussidsc.global.valuesalors que ce champ n’est pas utilisé.La documentation des champs values dans la CRD est ambiguë ou incorrecte sur les clés de merge et les emplacements utilisés par les charts/roles. Elle ne distingue pas clairement GitLab (CR GitLab vs chart de l’opérateur). La CRD expose aussi dsc.global.values alors que ce champ n’est pas utilisé.
Quel est le nouveau comportement ?
valuesdans la CRD indiquent précisément les clés de merge et les chemins de base utilisés.dsc.gitlab.values(CR GitLab) etdsc.gitlabOperator.values(chart opérateur) est explicitée.dsc.global.valuesest retiré de la CRD car non utilisé.Cette PR introduit-elle un breaking change ?
Non. Il s’agit de corrections de documentation.
Hormis la suppressions de
dsc.global.values(inutilisé) bien sûr.