changement du registry haproxy de redis‑ha d'Argo CD#1044
Open
benji78 wants to merge 2 commits into
Open
Conversation
…move redundant registry condition
benji78
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quel est le comportement actuel ?
Quand
public.ecr.awsn’est pas disponible, l’instance haproxy duredis-had’Argo CD ne peut pas être installée, car le chartredis-hapointe par défaut surpublic.ecr.aws/docker/library/haproxy. Or, cette même image est disponible surdocker.io/library/haproxy(sachant que/xxx,/library/xxxet/_/xxxsont synonymes sur docker hub).Quel est le nouveau comportement ?
L'image haproxy de
redis-haest explicitement redirigé versdocker.io/library/haproxy(via le registre Docker configuré), ce qui permet l’installation même lorsquepublic.ecr.awsest inaccessible (offline ou filtrage réseau).Concernant l'Argo CD d'infra, la condition redondante est simplifiée et le tag pour l'image redis-ha devient indépendant du registre. Pour rappel, redis 7.4 est la dernière version sous license BSD.
Cette PR introduit-elle un breaking change ?
Non
Autres informations
Valkey pourrait être utilisé à la place de Redis !