SW-6725: Allow Rails 7.x (raise gemspec rails ceiling to < 8.0)#5
Open
slad-cloudapp wants to merge 1 commit into
Open
SW-6725: Allow Rails 7.x (raise gemspec rails ceiling to < 8.0)#5slad-cloudapp wants to merge 1 commit into
slad-cloudapp wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the scim_rails gem dependency constraints so it can be resolved alongside Rails 7.2.x (and generally all Rails 7.x) in downstream apps, unblocking the Rails 6.1 → 7.2 upgrade noted in the PR description.
Changes:
- Relax the Rails dependency upper bound from
<= 7.1to< 8.0in the gemspec.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
19
to
+20
| s.required_ruby_version = ">= 2.4" | ||
| s.add_dependency "rails", ">= 6.0", "<= 7.1" | ||
| s.add_dependency "rails", ">= 6.0", "< 8.0" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
dropper_api is upgrading Rails 6.1 → 7.2.3.1 (SW-6714). This fork's gemspec caps the Rails dependency at
<= 7.1, so bundler cannot resolvescim_railsagainst Rails 7.2 — a hard blocker for the upgrade.What?
One-line change to
scim_rails.gemspec:Raises the ceiling to allow all of Rails 7.x. No functional/code changes to the gem — the SCIM controllers, config, and group functionality are untouched.
Caveats
< 8.0intentionally).gem "scim_rails", github: "cloudapp/scim_rails", branch: "rails-7-2"). Once this merges tomain, that PR will drop thebranch:pin. Please do not delete therails-7-2branch until dropper_api's SW-6714 has merged and re-locked — the production bundle resolves against it in the meantime.Testing Notes
Tracked by SW-6725.