tss/rsa: Rewrite serialization functions for KeyShare and SignShare#454
Open
armfazh wants to merge 1 commit intotssRSAveriffrom
Open
tss/rsa: Rewrite serialization functions for KeyShare and SignShare#454armfazh wants to merge 1 commit intotssRSAveriffrom
armfazh wants to merge 1 commit intotssRSAveriffrom
Conversation
armfazh
changed the title
bwesterb
approved these changes
Jan 3, 2024
|
|
||
| // UnmarshalBinary recovers a value from a byte array. | ||
| // Returns an error if the recovered value is invalid. | ||
| // Any panic raised when calling to ReadValue is recovered and an error is returned instead. |
Contributor
Author
There was a problem hiding this comment.
this helper function generically implements UnmarshalBinary if there is an implementation of ReadValue (which internally uses the cryptobyte package).
| ok := v.ReadValue(&r) | ||
| if !ok { | ||
| return fmt.Errorf("cannot read %T from input string", v) | ||
| } |
Member
There was a problem hiding this comment.
What if there are trailing bytes in data?
Contributor
Author
There was a problem hiding this comment.
it consumes only the data needed by the implementor, so this allows to do reading continuations in composed data structures. User can call Empty() to check for trailing data.
bwesterb
requested changes
Jan 3, 2024
Member
bwesterb
left a comment
bwesterb
left a comment
There was a problem hiding this comment.
See comments in previous review.
|
why wasn' this PR merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use cryptoybyte to leverage TLS syntax. Serialization of KeyShare and SignShares.
Staked on top of #453