[Docs] Fix cramped docs layout on mobile and tablet viewports#443
Open
pedromenezes1 wants to merge 8 commits intomainfrom
Open
[Docs] Fix cramped docs layout on mobile and tablet viewports#443pedromenezes1 wants to merge 8 commits intomainfrom
pedromenezes1 wants to merge 8 commits intomainfrom
Conversation
commit: |
3ddff2f to
d8dfb5f
Compare
Contributor
Docs PreviewCommit: |
Contributor
Collaborator
Author
|
/bonk |
Contributor
|
I've reviewed all the changes in PR #443. This is a well-executed responsive layout improvement that follows the project's conventions. Here's my analysis: SummaryThe PR improves the documentation site's mobile and tablet experience by:
Code Review✅ Follows Conventions
Files Changed Analysis
Visual Regression ResultsThe visual regression shows 18 changed screenshots with minor pixel changes (0.13% - 1.03% differences). These are expected and correct - they're side effects of the padding changes affecting component demos that render within the docs layout. The changes are primarily in Button, Dialog, and Select components which appear in documentation examples. ConclusionThis is a well-crafted PR that:
LGTM 👍 - The responsive improvements are solid and the implementation is clean. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








































































The docs had a flat 48px padding at every viewport, leaving phones with cramped content, and the desktop sidebar rendered on tablets too, further crowding the layout.
This introduces a tiered horizontal padding scale (
px-3→md:px-6→lg:p-12) and gates the desktop sidebar atlg:(≥1024px), so tablets now use the same mobile drawer UX as phones. Chrome bars (hamburger, sticky doc header, TOC select) share the same tiers. Verified at 475/767/768/1023/1024/1920px.