Open
Conversation
- Change close buttons from secondary to ghost variant for consistency - Update "With Actions" demo to show save workflow instead of delete - Add alertdialog role to confirmation demo and update description to explain disablePointerDismissal behavior - Wrap primary action buttons in Dialog.Close for proper dismissal - Add JSDoc note about excluding header close button from alertdialog role - Add descriptive text to "With Actions" example section
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(dialog): clarify alertdialog usage and fix demo inconsistencies
Improves the Dialog component documentation and demo examples to better
communicate the distinction between
dialogandalertdialogroles.Changes:
Dialog.Rootroleprop clarifyingthat
alertdialogshould not include a header close button — users mustrespond via explicit action buttons in the footer
"Save changes" flow (previously used "Delete"), reserving destructive
actions for
alertdialogdemos onlyrole="alertdialog"to DialogConfirmationDemofor correct accessibility semantics
Dialog.CloseinDialogWithSelectDemo and DialogWithComboboxDemo so they close the dialog