Skip to content

fix(sidebar): show collapsible groups in mobile drawer#450

Open
Thereallo1026 wants to merge 1 commit intocloudflare:mainfrom
Thereallo1026:fix/sidebar-mobile-collapsible
Open

fix(sidebar): show collapsible groups in mobile drawer#450
Thereallo1026 wants to merge 1 commit intocloudflare:mainfrom
Thereallo1026:fix/sidebar-mobile-collapsible

Conversation

@Thereallo1026
Copy link
Copy Markdown

Fixes #366.

Summary

  • Treat the open mobile sidebar drawer as an expanded sidebar root
  • Add the named group/sidebar ancestor contract to the mobile drawer
  • Preserve sidebar data attributes on mobile so collapsible group content can resolve expanded-state styles

pnpm --filter @cloudflare/kumo exec tsc --noEmit for testing. Manually verified at mobile viewport width that collapsible group children render in the sidebar drawer.


  • Reviews
    • bonk has reviewed the change
    • automated review not possible because: external OSS maintainer without bonk access
  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows: verified the Sidebar Collapsible Groups demo at mobile width before and after the fix; ran pnpm --filter @cloudflare/kumo exec tsc --noEmit
    • Additional testing not necessary because:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] Sidebar: No collapsible visibility on Mobile.

1 participant