Skip to content

docs: add select placeholder to home grid#453

Merged
mattrothenberg merged 1 commit intomainfrom
docs/select-placeholder-home-grid
Apr 27, 2026
Merged

docs: add select placeholder to home grid#453
mattrothenberg merged 1 commit intomainfrom
docs/select-placeholder-home-grid

Conversation

@mattrothenberg
Copy link
Copy Markdown
Collaborator

@mattrothenberg mattrothenberg commented Apr 27, 2026

Summary

  • Adds a placeholder to the Select example in the homepage component grid.

Before
Screenshot 2026-04-27 at 12 16 53 PM

After
Screenshot 2026-04-27 at 12 17 04 PM

Validation

  • pnpm --filter @cloudflare/kumo-docs-astro typecheck

  • pnpm --filter @cloudflare/kumo-docs-astro lint currently fails on existing unrelated docs lint errors.

  • Reviews

  • bonk has reviewed the change

  • automated review not possible because: docs-only one-line placeholder update

  • Tests

  • Tests included/updated

  • Automated tests not possible - manual testing has been completed as follows:

  • Additional testing not necessary because: docs-only one-line placeholder update; package typecheck passes

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 27, 2026

npm i https://pkg.pr.new/@cloudflare/kumo@453

commit: e022149

@mattrothenberg
Copy link
Copy Markdown
Collaborator Author

/bonk

@github-actions
Copy link
Copy Markdown
Contributor

Docs Preview

View docs preview

Commit: ec464a3

Copy link
Copy Markdown
Contributor

@ask-bonk ask-bonk Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Simple, focused improvement that makes the Select demo clearer. The placeholder helps users understand the component's initial state before selection.

@ask-bonk
Copy link
Copy Markdown
Contributor

ask-bonk Bot commented Apr 27, 2026

Approved! ✅

github run

@mattrothenberg mattrothenberg merged commit 8f9a367 into main Apr 27, 2026
16 of 18 checks passed
@mattrothenberg mattrothenberg deleted the docs/select-placeholder-home-grid branch April 27, 2026 16:20
@github-actions
Copy link
Copy Markdown
Contributor

Visual Regression Report — 6 changed, 31 unchanged

6 screenshot(s) with visual changes:

Button / Loading State

6 px (0.01%) changed

Before After Diff
Before After Diff

Dialog (Open)

0 px (0%) changed

Before After Diff
Before After Diff

Select / Select Sizes

599 px (0.32%) changed

Before After Diff
Before After Diff

Select / Select Loading

2,255 px (1.12%) changed

Before After Diff
Before After Diff

Select / Select Complex

720 px (0.61%) changed

Before After Diff
Before After Diff

Select (Open)

722 px (0%) changed

Before After Diff
Before After Diff
31 screenshot(s) unchanged
  • Button / Basic
  • Button / Variant: Primary
  • Button / Variant: Secondary
  • Button / Variant: Ghost
  • Button / Variant: Destructive
  • Button / Variant: Outline
  • Button / Variant: Secondary Destructive
  • Button / Sizes
  • Button / With Icon
  • Button / Icon Only
  • Button / Disabled State
  • Button / Title
  • Dialog / Dialog With Actions
  • Dialog / Dialog Basic
  • Dialog / Dialog Alert
  • Dialog / Dialog Confirmation
  • Dialog / Dialog With Select
  • Dialog / Dialog With Combobox
  • Dialog / Dialog With Dropdown
  • Select / Select Basic
  • Select / Select Without Label
  • Select / Select With Field
  • Select / Select Placeholder
  • Select / Select With Tooltip
  • Select / Select Custom Rendering
  • Select / Select Multiple
  • Select / Select Disabled Options
  • Select / Select Disabled Items
  • Select / Select Grouped
  • Select / Select Grouped With Disabled
  • Select / Select Long List

Generated by Kumo Visual Regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant