Skip to content

fix(tokens): text token variant updates#454

Open
najlaskr wants to merge 1 commit intocloudflare:mainfrom
najlaskr:text-tokens
Open

fix(tokens): text token variant updates#454
najlaskr wants to merge 1 commit intocloudflare:mainfrom
najlaskr:text-tokens

Conversation

@najlaskr
Copy link
Copy Markdown
Contributor

@najlaskr najlaskr commented Apr 27, 2026

Problem

In the current text token mapping, semantic naming and rendered behavior are misaligned, particularly in dark mode. This creates ambiguity in both design intent and implementation, specifically:

  • Distinct tokens collapse to the same visual output: text-kumo-strong and text-kumo-subtle both map to neutral-400 in dark mode.
  • Tokens are applied interchangeably across components, which weakens the intended semantic hierarchy and makes usage less predictable.
Screenshot 2026-04-27 at 3 26 46 PM

What changed

  • Updated semantic text token definitions so emphasis levels map correctly in both light and dark modes.
  • Remapped text-kumo-strong to a higher-emphasis value
  • Adjusted text-kumo-inactive to a lighter/inactive value to prevent overlap with active/supporting text roles
  • Replaced text-kumo-strong with text-kumo-subtle in components where content is secondary (metadata, helper labels, supporting UI text)
  • Applied the same semantic token updates across docs examples and Figma generator output so previews and generated artifacts match library behavior
  • Regenerated theme output to reflect the new token mappings end-to-end.
Screenshot 2026-04-27 at 3 36 19 PM
  • Reviews
    • bonk has reviewed the change
    • automated review not possible because: no access to bonk
  • Tests
    • Tests included/updated
    • Automated tests not possible - manual testing has been completed as follows: ran pnpm typecheck, pnpm lint and pnpm test as well as manual QA through docs
    • Additional testing not necessary because:

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 28, 2026

npm i https://pkg.pr.new/@cloudflare/kumo@454

commit: 2c0798d

@github-actions
Copy link
Copy Markdown
Contributor

Docs Preview

View docs preview

Commit: 2c0798d

@github-actions
Copy link
Copy Markdown
Contributor

Visual Regression Report — 11 changed, 27 unchanged

11 screenshot(s) with visual changes:

Button / Variant: Destructive

1,112 px (1.1%) changed

Before After Diff
Before After Diff

Button / Loading State

1 px (0%) changed

Before After Diff
Before After Diff

Button / Title

422 px (0.42%) changed

Before After Diff
Before After Diff

Dialog / Dialog Basic

114 px (0.11%) changed

Before After Diff
Before After Diff

Dialog (Open)

0 px (0%) changed

Before After Diff
Before After Diff

Select / Select Sizes

663 px (0.36%) changed

Before After Diff
Before After Diff

Select / Select Without Label

161 px (0.16%) changed

Before After Diff
Before After Diff

Select / Select With Field

795 px (0.67%) changed

Before After Diff
Before After Diff

Select / Select Loading

0 px (0%) changed

Before After Diff
Before After Diff

Select / Select Disabled Items

231 px (0.23%) changed

Before After Diff
Before After Diff

Select (Open)

13,838 px (0.06%) changed

Before After Diff
Before After Diff
27 screenshot(s) unchanged
  • Button / Basic
  • Button / Variant: Primary
  • Button / Variant: Secondary
  • Button / Variant: Ghost
  • Button / Variant: Outline
  • Button / Variant: Secondary Destructive
  • Button / Sizes
  • Button / With Icon
  • Button / Icon Only
  • Button / Disabled State
  • Button / Link as Button
  • Dialog / Dialog With Actions
  • Dialog / Dialog Alert
  • Dialog / Dialog Confirmation
  • Dialog / Dialog With Select
  • Dialog / Dialog With Combobox
  • Dialog / Dialog With Dropdown
  • Select / Select Basic
  • Select / Select Placeholder
  • Select / Select With Tooltip
  • Select / Select Custom Rendering
  • Select / Select Multiple
  • Select / Select Complex
  • Select / Select Disabled Options
  • Select / Select Grouped
  • Select / Select Grouped With Disabled
  • Select / Select Long List

Generated by Kumo Visual Regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants