Skip to content

fix(input-group): added mb-0 to prevent layout shifts in stratus #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattrothenberg merged 1 commit into from
Apr 28, 2026
+8 −3
Merged

fix(input-group): added mb-0 to prevent layout shifts in stratus #456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/input-group-label-margin-reset.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@cloudflare/kumo": patch
---

Fix `InputGroup` label wrappers to enforce `mb-0`, preventing inherited label margins from shifting layout and click-target overlays.
6 changes: 3 additions & 3 deletions packages/kumo/src/components/input-group/input-group.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ const Root = forwardRef<
<label
htmlFor={inputId}
// Positioned behind children (z-0) so it catches clicks on empty space
className="absolute inset-0 z-0 cursor-text"
className="absolute inset-0 z-0 cursor-text !mb-0"
aria-hidden="true"
/>
)}
Expand Down Expand Up @@ -283,7 +283,7 @@ const Root = forwardRef<
<label
htmlFor={inputId}
// Positioned behind children (z-0) so it catches clicks on empty space
className="absolute inset-0 z-0"
className="absolute inset-0 z-0 !mb-0"
aria-hidden="true"
/>
{children}
Expand All @@ -293,7 +293,7 @@ const Root = forwardRef<
<label
ref={forwardedRef as React.Ref<HTMLLabelElement>}
{...dataProps}
className={containerClassName}
className={cn(containerClassName, "!mb-0")}
{...rest}
>
{children}
Expand Down
Loading