Open
Conversation
posilva
force-pushed
the
feature/add_support_to_aws_s3_storage
branch
from
d2bd207 to
ff446c1
Compare
Contributor
|
@posilva - thanks for this. Will review soon. I should also mention that Enterprise customers are now able to join our Logpush beta, where we can continuously push request logs to an S3 (or GCS) bucket for you. Email msilverlock @ cloudflare if that’s relevant to you. |
When using aws-s3-compress we need to ensure we first close the GzWriter before the PipeWriter to avoid having "corrupted" JSON in the logs, this was observed when trying to use AWS Athena to query the Logs
Author
|
@elithrar - I made a fix to the previous PR because I was getting some "corrupt/incomplete" log entries when using aws-s3-compress option.
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support to upload logs to AWS S3 bucket with or without compression