Skip to content

fix: prevent gateway double-spawn when process undetected by listProcesses() #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amit183239 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: prevent gateway double-spawn when process undetected by listProcesses() #293

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions src/gateway/process.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ export async function findExistingMoltbotProcess(sandbox: Sandbox): Promise<Proc
const isGatewayProcess =
proc.command.includes('start-openclaw.sh') ||
proc.command.includes('openclaw gateway') ||
// Match full-path bash/sh invocations (e.g. "bash /usr/local/bin/start-openclaw.sh")
proc.command.includes('/usr/local/bin/start-openclaw.sh') ||
// Legacy: match old startup script during transition
proc.command.includes('start-moltbot.sh') ||
proc.command.includes('clawdbot gateway');
Expand Down Expand Up @@ -88,6 +90,24 @@ export async function ensureMoltbotGateway(sandbox: Sandbox, env: MoltbotEnv): P
}
}

// Before spawning, do a TCP probe on the gateway port.
// If the port is already open the gateway is running but was undetected by listProcesses()
// (e.g. the command string didn't match any known pattern). Skip the spawn to prevent
// the "gateway already running / port in use" lock error.
try {
const portCheck = await sandbox.exec(
`timeout 2 bash -c 'echo > /dev/tcp/localhost/${MOLTBOT_PORT}' 2>/dev/null && echo 'open' || echo 'closed'`,
);
if (portCheck.stdout?.trim() === 'open') {
console.log(`Port ${MOLTBOT_PORT} already open — gateway running but undetected, skipping spawn`);
const procs = await sandbox.listProcesses();
const any = procs.find((p) => p.status === 'running' || p.status === 'starting');
if (any) return any;
}
} catch {
// Port probe failed — proceed to start normally
}

// Start a new OpenClaw gateway
console.log('Starting new OpenClaw gateway...');
const envVars = buildEnvVars(env);
Expand Down