Adds chatroom example using DO hibernation API#53
Merged
Conversation
dom96
force-pushed
the
dominik/chatroom
branch
2 times, most recently
from
7fea939 to
1bd9dc9
Compare
hoodmane
reviewed
Nov 25, 2025
hoodmane
reviewed
Nov 25, 2025
hoodmane
reviewed
Nov 25, 2025
Comment on lines
+16
to
+17
| self.message_history = [] # Limited message history | ||
| self.max_history = 50 # Maximum number of messages to keep |
Contributor
There was a problem hiding this comment.
We can make message_history into a deque:
from collections import deque
self.message_history = deque(maxlen=50)
Old messages then get discarded automatically.
Contributor
Author
There was a problem hiding this comment.
Good idea, but that fails with:
TypeError: Object of type deque is not JSON serializable
hoodmane
approved these changes
Nov 25, 2025
Contributor
hoodmane
left a comment
hoodmane
left a comment
There was a problem hiding this comment.
Looks great, I left a couple of minor comments.
dom96
force-pushed
the
dominik/chatroom
branch
from
0cc2b4e to
8bbb004
Compare
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Works locally but still waiting for fixes to be released out to the validator.
