Skip to content

Set a default date for perf_hooks, v8, tty, child_process, worker_threads, readline, repl, and performance classes modules #6135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
petebacondarwin wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −15
Draft

Set a default date for perf_hooks, v8, tty, child_process, worker_threads, readline, repl, and performance classes modules #6135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/workerd/api/node/tests/child_process-nodejs-test.wd-test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const unitTests :Workerd.Config = (
modules = [
(name = "worker", esModule = embed "child_process-nodejs-test.js")
],
compatibilityFlags = ["nodejs_compat", "nodejs_compat_v2", "enable_nodejs_child_process_module", "experimental"],
compatibilityFlags = ["nodejs_compat", "nodejs_compat_v2", "enable_nodejs_child_process_module"],
)
),
],
Expand Down
2 changes: 1 addition & 1 deletion src/workerd/api/node/tests/tty-nodejs-test.wd-test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const unitTests :Workerd.Config = (
modules = [
(name = "worker", esModule = embed "tty-nodejs-test.js")
],
compatibilityFlags = ["nodejs_compat", "nodejs_compat_v2", "enable_nodejs_tty_module", "experimental"]
compatibilityFlags = ["nodejs_compat", "nodejs_compat_v2", "enable_nodejs_tty_module"]
)
),
],
Expand Down
2 changes: 1 addition & 1 deletion src/workerd/api/node/tests/v8-nodejs-test.wd-test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const unitTests :Workerd.Config = (
modules = [
(name = "worker", esModule = embed "v8-nodejs-test.js")
],
compatibilityFlags = ["nodejs_compat", "nodejs_compat_v2", "enable_nodejs_v8_module", "experimental"]
compatibilityFlags = ["nodejs_compat", "nodejs_compat_v2", "enable_nodejs_v8_module"]
)
),
],
Expand Down
2 changes: 1 addition & 1 deletion src/workerd/api/node/tests/worker_threads-nodejs-test.wd-test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const unitTests :Workerd.Config = (
modules = [
(name = "worker", esModule = embed "worker_threads-nodejs-test.js")
],
compatibilityFlags = ["nodejs_compat", "nodejs_compat_v2", "enable_nodejs_worker_threads_module", "experimental", "global_navigator"]
compatibilityFlags = ["nodejs_compat", "nodejs_compat_v2", "enable_nodejs_worker_threads_module", "global_navigator"]
)
),
],
Expand Down
19 changes: 8 additions & 11 deletions src/workerd/io/compatibility-date.capnp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1064,15 +1064,14 @@ struct CompatibilityFlags @0x8f8c1b68151b6cef {
enableNodeJsPerfHooksModule @122 :Bool
$compatEnableFlag("enable_nodejs_perf_hooks_module")
$compatDisableFlag("disable_nodejs_perf_hooks_module")
$experimental;
# $impliedByAfterDate(name = "nodeJsCompat", date = "2025-10-01");
$impliedByAfterDate(name = "nodeJsCompat", date = "2026-03-10");
# Enables the Node.js perf_hooks module. It is required to use this flag with
# nodejs_compat (or nodejs_compat_v2).

enableGlobalPerformanceClasses @123 :Bool
$compatEnableFlag("enable_global_performance_classes")
$compatDisableFlag("disable_global_performance_classes")
$experimental;
$impliedByAfterDate(name = "enableNodeJsPerfHooksModule", date = "2026-03-10");
# Enables PerformanceEntry, PerformanceMark, PerformanceMeasure, PerformanceResourceTiming,
# PerformanceObserver and PerformanceObserverEntryList global classes.

Expand All @@ -1086,16 +1085,14 @@ struct CompatibilityFlags @0x8f8c1b68151b6cef {
enableNodeJsV8Module @125 :Bool
$compatEnableFlag("enable_nodejs_v8_module")
$compatDisableFlag("disable_nodejs_v8_module")
$experimental;
# $impliedByAfterDate(name = "nodeJsCompat", date = "2025-10-15");
$impliedByAfterDate(name = "nodeJsCompat", date = "2026-03-10");
# Enables the Node.js non-functional stub v8 module. It is required to use this flag with
# nodejs_compat (or nodejs_compat_v2).

enableNodeJsTtyModule @126 :Bool
$compatEnableFlag("enable_nodejs_tty_module")
$compatDisableFlag("disable_nodejs_tty_module")
$experimental;
# $impliedByAfterDate(name = "nodeJsCompat", date = "2025-10-15");
$impliedByAfterDate(name = "nodeJsCompat", date = "2026-03-10");
# Enables the Node.js non-functional stub tty module. It is required to use this flag with
# nodejs_compat (or nodejs_compat_v2).

Expand All @@ -1116,14 +1113,14 @@ struct CompatibilityFlags @0x8f8c1b68151b6cef {
enableNodeJsChildProcessModule @129 :Bool
$compatEnableFlag("enable_nodejs_child_process_module")
$compatDisableFlag("disable_nodejs_child_process_module")
$experimental;
$impliedByAfterDate(name = "nodeJsCompat", date = "2026-03-10");
# Enables the Node.js non-functional stub child_process module. It is required to use this
# flag with nodejs_compat (or nodejs_compat_v2).

enableNodeJsWorkerThreadsModule @130 :Bool
$compatEnableFlag("enable_nodejs_worker_threads_module")
$compatDisableFlag("disable_nodejs_worker_threads_module")
$experimental;
$impliedByAfterDate(name = "nodeJsCompat", date = "2026-03-10");
# Enables the Node.js non-functional stub worker_threads module. It is required to use this
# flag with nodejs_compat (or nodejs_compat_v2).

Expand Down Expand Up @@ -1165,14 +1162,14 @@ struct CompatibilityFlags @0x8f8c1b68151b6cef {
enableNodeJsReadlineModule @136 :Bool
$compatEnableFlag("enable_nodejs_readline_module")
$compatDisableFlag("disable_nodejs_readline_module")
$experimental;
$impliedByAfterDate(name = "nodeJsCompat", date = "2026-03-10");
# Enables the Node.js non-functional stub readline module. It is required to use this
# flag with nodejs_compat (or nodejs_compat_v2).

enableNodeJsReplModule @137 :Bool
$compatEnableFlag("enable_nodejs_repl_module")
$compatDisableFlag("disable_nodejs_repl_module")
$experimental;
$impliedByAfterDate(name = "nodeJsCompat", date = "2026-03-10");
# Enables the Node.js non-functional stub repl module. It is required to use this
# flag with nodejs_compat (or nodejs_compat_v2).

Expand Down