Skip to content

Add us to DurableObjectJurisdiction type#6831

Open
KirillTim wants to merge 2 commits into
mainfrom
ktimofeev/jurisdiction-type-hint
Open

Add us to DurableObjectJurisdiction type#6831
KirillTim wants to merge 2 commits into
mainfrom
ktimofeev/jurisdiction-type-hint

Conversation

@KirillTim

Copy link
Copy Markdown

Also fix an outdated documentation link.

@KirillTim KirillTim requested review from a team as code owners June 19, 2026 16:25
@KirillTim KirillTim requested a review from edmundhung June 19, 2026 16:25
@github-actions

github-actions Bot commented Jun 19, 2026

Copy link
Copy Markdown

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@KirillTim

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

github-actions Bot added a commit that referenced this pull request Jun 19, 2026
@ask-bonk

ask-bonk Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

The extra changes in the snapshot files (like restore, apac-ne, apac-se) are from the merge with main picking up other changes that were already in the source but not yet regenerated in the snapshots. This is expected.

Let me now assess the overall PR:

  1. actor.h changes: Adding "us" to the DurableObjectJurisdiction type union and updating the documentation link. Both are clean, correct changes.
  2. Generated snapshot files: Properly regenerated. The extra diffs beyond DurableObjectJurisdiction are from the type generator catching up with other source changes (like apac-ne/apac-se location hints and the restore method).
  3. Documentation link: The new link https://developers.cloudflare.com/durable-objects/reference/data-location/#restrict-durable-objects-to-a-jurisdiction is valid and correct.

The only potential issue: the Cloudflare docs page currently doesn't list "us" as a supported jurisdiction (only eu and fedramp). But fedramp-high was already in the type before this PR and isn't on the docs page either, suggesting the type definition intentionally includes values beyond what's publicly documented. The PR author (KirillTim) appears to be a Cloudflare employee based on the branch name pattern, so they likely know about internal jurisdiction values.

This is a clean, minimal type-hint addition with no behavioral changes, no security implications, and no backward compatibility concerns (adding a new union member is additive). The generated snapshots were properly regenerated.

LGTM

github run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants