Add new feature excel download#120
Merged
ImMin5 merged 1 commit intocloudforet-io:masterfrom May 13, 2025
Merged
Conversation
Signed-off-by: ImMin5 <mino@megazone.com>
There was a problem hiding this comment.
Pull Request Overview
This PR implements a new feature for Excel download functionality and cleans up unused API models. Key changes include the addition of Excel request models and REST endpoints, enhancements to the CloudforetManager with pagination and URL parsing improvements, and necessary configuration updates.
- Removed unused resource and auth request models.
- Added new Excel export and download endpoints with corresponding request models.
- Updated pagination logic and cache configuration in the manager and global settings.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/cloudforet/console_api_v2/model/resource.py | Removed unused API resource models. |
| src/cloudforet/console_api_v2/model/excel/request.py | Added new models for Excel export/download requests. |
| src/cloudforet/console_api_v2/model/auth/request.py | Removed obsolete authentication request model. |
| src/cloudforet/console_api_v2/manager/cloudforet_manager.py | Added pagination and URL-based gRPC method conversion logic. |
| src/cloudforet/console_api_v2/interface/rest/extension/excel.py | Introduced REST endpoints for Excel export and download. |
| src/cloudforet/console_api_v2/conf/router_conf.py | Configured new router for the Excel extension. |
| src/cloudforet/console_api_v2/conf/global_conf.py | Increased cache max_size for local configuration. |
| pkg/pip_requirements.txt | Added openpyxl dependency. |
| def convert_grpc_method_from_url(cls, url: str) -> str: | ||
| try: | ||
| parts = url.strip("/").split("/") | ||
| print(parts) |
There was a problem hiding this comment.
Remove the debug print statement or replace it with a logging call to avoid accidentally exposing internal state in production.
Suggested change
| print(parts) | |
| _LOGGER.debug(parts) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category
Description
Known issue