Skip to content

fix(alert-manager): solve alert-manager empty page issue #5655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
piggggggggy merged 2 commits into from
Feb 21, 2025
Merged

fix(alert-manager): solve alert-manager empty page issue #5655

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52f71d4
fix(alert): solve webhook icon issue
piggggggggy Feb 21, 2025
db9e03b
fix(alert): add defensive code
piggggggggy Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/web/src/services/alert-manager/components/AlertDetailInfoTable.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ const tableState = reactive({

const getCreatedByNames = (id: string): string => {
if (id.includes('webhook')) {
return storeState.webhook[id].label || id;
return storeState.webhook[id]?.label || id;
}
return id || '--';
};
Expand Down
2 changes: 1 addition & 1 deletion apps/web/src/services/alert-manager/components/AlertsManagementTable.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ const labelMenuItemsHandler = (): AutocompleteHandler => async (inputText: strin
};
const getCreatedByNames = (id: string): string => {
if (id.includes('webhook')) {
return storeState.webhook[id].label || id;
return storeState.webhook[id]?.label || id;
}
return id;
};
Expand Down
2 changes: 1 addition & 1 deletion apps/web/src/services/alert-manager/components/ServiceListContent.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ const state = reactive({

const getEscalationPolicyLabel = (id: string): string => storeState.escalationPolicy[id]?.label || '';
const getWebhookIcon = (id: string): string|undefined => {
const webhook = storeState.webhook[id].data;
const webhook = storeState.webhook[id]?.data;
if (!webhook) return undefined;
return storeState.plugins[webhook.plugin_info.plugin_id]?.icon || '';
};
Expand Down
2 changes: 1 addition & 1 deletion apps/web/src/services/asset-inventory-v1/components/CloudServiceAlertsTab.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ const fetchAlerts = async () => {
};
const getCreatedByNames = (id: string): string => {
if (id.includes('webhook')) {
return storeState.webhook[id].label || id;
return storeState.webhook[id]?.label || id;
}
return id;
};
Expand Down
Loading