Skip to content

feat(release-20250423-4)#5816

Merged
piggggggggy merged 3 commits intomasterfrom
develop
Apr 23, 2025
Merged

feat(release-20250423-4)#5816
piggggggggy merged 3 commits intomasterfrom
develop

Conversation

@piggggggggy
Copy link
Copy Markdown
Member

Skip Review (optional)

  • Minor changes that don't affect the functionality (e.g. style, chore, ci, test, docs)
  • Previously reviewed in feature branch, further review is not mandatory
  • Self-merge allowed for solo developers or urgent changes

Description (optional)

Things to Talk About (optional)

@piggggggggy piggggggggy added the self_approved/review Pull Request has been reviewed and approved by the author without requiring additional reviewers. label Apr 23, 2025
@piggggggggy piggggggggy requested a review from Copilot April 23, 2025 13:08
@github-actions
Copy link
Copy Markdown
Contributor

⚠️ @piggggggggy the signed-off-by was not found in the following 2 commits:

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <randomdeveloper@example.com>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the WidgetFormOverlayStep2 component to streamline the field manager initialization and update rendering conditions. Key changes include:

  • Removing the separate "fieldManager" variable and integrating it as a computed property within the reactive state.
  • Adding additional safety checks (e.g. ensuring "widget" exists) in computed properties and template rendering conditions.
  • Refining the template v-if condition for the widget form overlay for improved reliability.

@github-actions
Copy link
Copy Markdown
Contributor

✅ There are no commits in this PR that require review.

@piggggggggy piggggggggy merged commit 9d3d222 into master Apr 23, 2025
10 of 14 checks passed
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
console 🔄 Building (Inspect) Visit Preview 💬 Add feedback Apr 23, 2025 1:10pm
web-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2025 1:10pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
dashboard ⬜️ Ignored (Inspect) Apr 23, 2025 1:10pm
feature-integration-project-detail ⬜️ Ignored (Inspect) Apr 23, 2025 1:10pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fail/signedoff self_approved/review Pull Request has been reviewed and approved by the author without requiring additional reviewers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants