Skip to content

feat: merge to master#5868

Merged
seungyeoneeee merged 4 commits intomasterfrom
develop
May 21, 2025
Merged

feat: merge to master#5868
seungyeoneeee merged 4 commits intomasterfrom
develop

Conversation

@seungyeoneeee
Copy link
Copy Markdown
Contributor

Skip Review (optional)

  • Minor changes that don't affect the functionality (e.g. style, chore, ci, test, docs)
  • Previously reviewed in feature branch, further review is not mandatory
  • Self-merge allowed for solo developers or urgent changes

Description (optional)

Things to Talk About (optional)

piggggggggy and others added 4 commits May 19, 2025 15:21
Signed-off-by: samuel.park <samuel.park@megazone.com>
Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
fix: fix timezone-aware time bug
@seungyeoneeee seungyeoneeee requested a review from Copilot May 21, 2025 04:22
@seungyeoneeee seungyeoneeee added the self_approved/review Pull Request has been reviewed and approved by the author without requiring additional reviewers. label May 21, 2025
@vercel
Copy link
Copy Markdown

vercel bot commented May 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
console ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2025 4:22am
web-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2025 4:22am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
dashboard ⬜️ Ignored (Inspect) May 21, 2025 4:22am
feature-integration-project-detail ⬜️ Ignored (Inspect) May 21, 2025 4:22am

@github-actions
Copy link
Copy Markdown
Contributor

✅ There are no commits in this PR that require review.

@github-actions
Copy link
Copy Markdown
Contributor

⚠️ @seungyeoneeee the signed-off-by was not found in the following 2 commits:

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <randomdeveloper@example.com>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Merge feature branch into master, updating time calculations and reviewer assignment logic.

  • Updated calculateTime to parse timestamps as UTC before converting to target timezone.
  • Simplified reviewer assignment to pick a single random reviewer in the GitHub Actions workflow.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
apps/web/src/services/alert-manager/v2/composables/alert-table-data.ts Switched dayjs.tz parsing to dayjs.utc(...).tz(...)
.github/workflows/pull_request_random_reviewer_assignment.yaml Changed from two reviewers to one and adjusted logging
Comments suppressed due to low confidence (2)

apps/web/src/services/alert-manager/v2/composables/alert-table-data.ts:53

  • The switch to parsing timestamps as UTC may alter behavior for edge cases; consider adding unit tests to validate calculateTime across different timezones and daylight saving transitions.
const createdTime = dayjs.utc(time).tz(timezone);

.github/workflows/pull_request_random_reviewer_assignment.yaml:36

  • Using sort(() => 0.5 - Math.random()) for shuffling can produce biased results and mutates the original array; consider implementing a Fisher–Yates shuffle on a copy of the array for unbiased randomization.
const shuffled = reviewers.sort(() => 0.5 - Math.random());

@seungyeoneeee seungyeoneeee merged commit 96bafa7 into master May 21, 2025
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fail/signedoff self_approved/review Pull Request has been reviewed and approved by the author without requiring additional reviewers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants