Conversation
Signed-off-by: samuel.park <samuel.park@megazone.com>
Signed-off-by: NaYeong,Kim <nayeongkim@megazone.com>
fix: fix timezone-aware time bug
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
✅ There are no commits in this PR that require review. |
|
✅ Why it is requiredThe Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO. Contributors sign-off that they adhere to these requirements by adding a Git even has a |
There was a problem hiding this comment.
Pull Request Overview
Merge feature branch into master, updating time calculations and reviewer assignment logic.
- Updated
calculateTimeto parse timestamps as UTC before converting to target timezone. - Simplified reviewer assignment to pick a single random reviewer in the GitHub Actions workflow.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/web/src/services/alert-manager/v2/composables/alert-table-data.ts | Switched dayjs.tz parsing to dayjs.utc(...).tz(...) |
| .github/workflows/pull_request_random_reviewer_assignment.yaml | Changed from two reviewers to one and adjusted logging |
Comments suppressed due to low confidence (2)
apps/web/src/services/alert-manager/v2/composables/alert-table-data.ts:53
- The switch to parsing timestamps as UTC may alter behavior for edge cases; consider adding unit tests to validate
calculateTimeacross different timezones and daylight saving transitions.
const createdTime = dayjs.utc(time).tz(timezone);
.github/workflows/pull_request_random_reviewer_assignment.yaml:36
- Using
sort(() => 0.5 - Math.random())for shuffling can produce biased results and mutates the original array; consider implementing a Fisher–Yates shuffle on a copy of the array for unbiased randomization.
const shuffled = reviewers.sort(() => 0.5 - Math.random());
Skip Review (optional)
style,chore,ci,test,docs)Description (optional)
Things to Talk About (optional)