fix: set min value from 0 to 1 (adjustment period)#5926
Merged
Conversation
Signed-off-by: yuda <yuda@megazone.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Contributor
|
✅ There are no commits in this PR that require review. |
Contributor
|
🎉 @piggggggggy has been randomly selected as the reviewer! Please review. 🙏 |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the minimum allowed value for the manual adjustment period from 0 to 1 in both validation logic and the UI input.
- Changed validation to reject values less than 1 and updated the corresponding i18n message key.
- Updated the
<p-text-input>minattribute to1to match the new rule.
Comments suppressed due to low confidence (2)
apps/web/src/services/cost-explorer/components/AdvancedSettingsCostReportConfiguration.vue:91
- Add or update unit tests to verify that values of 0 and negative numbers now trigger the 'greater than or equal to 1' validation error.
if (val < 1) return i18n.t('COST_EXPLORER.ADVANCED_SETTINGS.GREATER_THAN_OR_EQUAL_TO_1');
apps/web/src/services/cost-explorer/components/AdvancedSettingsCostReportConfiguration.vue:91
- Ensure the new i18n key 'COST_EXPLORER.ADVANCED_SETTINGS.GREATER_THAN_OR_EQUAL_TO_1' is defined in all locale files to avoid missing translation errors at runtime.
if (val < 1) return i18n.t('COST_EXPLORER.ADVANCED_SETTINGS.GREATER_THAN_OR_EQUAL_TO_1');
Signed-off-by: yuda <yuda@megazone.com>
Signed-off-by: yuda <yuda@megazone.com>
Contributor
|
✅ There are no commits in this PR that require review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip Review (optional)
style,chore,ci,test,docs)Description (optional)
Things to Talk About (optional)