hotfix: delete is_confirmed filter from cost report analyze API#5931
Merged
hotfix: delete is_confirmed filter from cost report analyze API#5931
is_confirmed filter from cost report analyze API#5931Conversation
Signed-off-by: yuda <yuda@megazone.com>
Signed-off-by: yuda <yuda@megazone.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Contributor
|
✅ There are no commits in this PR that require review. |
Contributor
|
🎉 @seungyeoneeee has been randomly selected as the reviewer! Please review. 🙏 |
There was a problem hiding this comment.
Pull Request Overview
Hotfix for cost report confirmation with minor changes to improve workspace data handling and report filtering.
- Updated workspace column logic to conditionally render the workspace field for admin users.
- Modified the value handler for the workspace field to use a reference-based approach.
- Removed the "is_confirmed: true" filter from the cost report detail page API query.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/web/src/services/cost-explorer/components/CostReportReportsTab.vue | Adjusted workspace column rendering and updated value handling for workspace data. |
| apps/web/src/common/pages/CostReportDetailPage.vue | Removed the "is_confirmed: true" filter from the API query. |
Comments suppressed due to low confidence (3)
apps/web/src/services/cost-explorer/components/CostReportReportsTab.vue:72
- Conditionally displaying the Workspace column for admin users may lead to differences in table structure between user roles; please confirm this behavior aligns with the intended design.
...(isAdminMode.value ? [{ label: 'Workspace', name: 'workspace_id' }] : []),
apps/web/src/services/cost-explorer/components/CostReportReportsTab.vue:88
- Switching from a distinct value handler to a reference value handler for the workspace field should be verified against backend expectations; if additional parameters or handling are required, please update accordingly.
workspace_id: makeReferenceValueHandler('identity.Workspace'),
apps/web/src/common/pages/CostReportDetailPage.vue:256
- Removing the 'is_confirmed: true' filter may affect the report data by including unconfirmed entries; please verify that this change reflects the desired functionality for report details.
is_confirmed: true,
yuda110
changed the title
is_confirmed filter from cost report analyze API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip Review (optional)
style,chore,ci,test,docs)Description (optional)
Things to Talk About (optional)