fix(top-bar): resolve menu display issue (missing store changes)#5942
Merged
piggggggggy merged 1 commit intomasterfrom Jun 17, 2025
Merged
fix(top-bar): resolve menu display issue (missing store changes)#5942piggggggggy merged 1 commit intomasterfrom
piggggggggy merged 1 commit intomasterfrom
Conversation
Signed-off-by: samuel.park <samuel.park@megazone.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
Contributor
|
🎉 @yuda110 has been randomly selected as the reviewer! Please review. 🙏 |
Contributor
|
✅ There are no commits in this PR that require review. |
piggggggggy
added
the
self_approved/review
There was a problem hiding this comment.
Pull Request Overview
This PR replaces user store-based permission checks with authorization store-based ones to resolve issues with menu display.
- Replace userStore with useAuthorizationStore in multiple components.
- Update the menu parameter type in TopBar.vue.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| apps/web/src/common/modules/portals/TopNotification.vue | Updated computed property for permissions using authorizationStore. |
| apps/web/src/common/modules/navigations/top-bar/modules/top-bar-toolset/modules/top-bar-notifications/TopBarNotifications.vue | Replaced userStore with authorizationStore for isNoRoleUser flag. |
| apps/web/src/common/modules/navigations/top-bar/modules/top-bar-toolset/modules/top-bar-notice/TopBarNotice.vue | Replaced userStore with authorizationStore for isNoRoleUser flag. |
| apps/web/src/common/modules/navigations/top-bar/modules/top-bar-toolset/modules/top-bar-integration/TopBarIntegration.vue | Switched to authorizationStore from userStore for role permissions. |
| apps/web/src/common/modules/navigations/top-bar/TopBar.vue | Changed to authorizationStore and updated the handleOpenMenu parameter type from MenuId to string. |
Comments suppressed due to low confidence (2)
apps/web/src/common/modules/navigations/top-bar/TopBar.vue:20
- There is a typo in the variable name 'athorizationStore'; please rename it to 'authorizationStore' for consistency.
const athorizationStore = useAuthorizationStore();
apps/web/src/common/modules/navigations/top-bar/TopBar.vue:39
- Changing the parameter type from MenuId to string might reduce the type safety of the menu identifier; if MenuId was previously enforcing specific values, consider retaining its use or documenting the change.
const handleOpenMenu = (menuId: string) => {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip Review (optional)
style,chore,ci,test,docs)Description (optional)
SSIA
Things to Talk About (optional)