Skip to content

chore: variation will be added later #5963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skdud4659 merged 1 commit into from
Jun 26, 2025
Merged

chore: variation will be added later #5963

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/web/src/services/cost-explorer/pages/admin/AdminAnomalyDetectionConfigurationPage.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,9 @@ const state = reactive<State>({
{ label: 'Fixed Amount', name: 'FIXED_AMOUNT' },
]),
variationMenu: computed(() => [
Copy link

Copilot AI Jun 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider removing this commented-out code or adding a TODO comment explaining why 'All' is disabled and when it will be re-enabled to improve code clarity.

Suggested change
variationMenu: computed(() => [
variationMenu: computed(() => [
// TODO: 'All' option is currently disabled due to incomplete implementation. Re-enable when the functionality for handling 'all' variations is added.

Copilot uses AI. Check for mistakes.
{ label: 'All', name: 'all' },
// { label: 'All', name: 'all' },
{ label: 'Increase (>=)', name: JSON.stringify(['gte']) },
Copy link

Copilot AI Jun 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider removing this commented-out code or adding a TODO comment explaining why 'Decrease (<=)' is disabled and when it will be re-enabled to improve code clarity.

Suggested change
{ label: 'Increase (>=)', name: JSON.stringify(['gte']) },
{ label: 'Increase (>=)', name: JSON.stringify(['gte']) },
// TODO: 'Decrease (<=)' is temporarily disabled due to [reason, e.g., pending design review or testing]. Re-enable when [condition, e.g., feature is approved or tested].

Copilot uses AI. Check for mistakes.
{ label: 'Decrease (<=)', name: JSON.stringify(['lte']) },
// { label: 'Decrease (<=)', name: JSON.stringify(['lte']) },
]),
notifyLevelMenu: computed(() => Object.values(NOTIFY_LEVEL_MAP).map((level) => ({
label: level.label,
Expand Down
Loading