This repository was archived by the owner on Jan 21, 2022. It is now read-only.
internal address for docker manager to be configurable#72
Open
nimakaviani wants to merge 1 commit into
Open
Conversation
|
✅ Hey nimakaviani! The commit authors and yourself have already signed the CLA. |
- if DOCKER_SERVER is provided, use that as the docker server internal address - otherwise fall back to 127.0.0.1 as the default docker server
nimakaviani
force-pushed
the
docker-server-env-var
branch
from
3bdfab4 to
d6acb84
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if DOCKER_SERVER is provided, use that as the docker server internal
address
otherwise fall back to 127.0.0.1 as the default docker server
document your feature
comment your code
update the README / how-to-run
have tests
get reviews