feat(auth): add GitHub App authentication#3
Open
hippolin wants to merge 3 commits intocloudfoundry-community:masterfrom
Open
feat(auth): add GitHub App authentication#3hippolin wants to merge 3 commits intocloudfoundry-community:masterfrom
hippolin wants to merge 3 commits intocloudfoundry-community:masterfrom
Conversation
Signed-off-by: Hippo Lin <hippo@hippo.idv.tw>
- Update GitHub App authentication models - Refactor fake implementations in models/fakes - Update dependency versions in go.mod and go.sum - Fix and refactor tests in prlist package - Update README documentation 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Add unit tests covering GitHub App authentication feature: - models/github_test.go: Tests for GitHub client factory with GitHub App support, including private key handling, endpoint configuration, and authentication routing between OAuth2 and GitHub App methods - models/git_test.go: Tests for Git client factory with GitHub App support, including token generation, environment variable setup, and option handling - pr/models_test.go: Tests for PR source validation ensuring proper authentication method configuration and mutual exclusivity - prlist/models_test.go: Tests for PRList source validation with same authentication checks plus PR state filtering validation All 55+ test cases pass with no regressions on existing functionality. 🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
hippolin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds GitHub App authentication support to the resource, providing an alternative to the traditional Personal Access Token authentication method. Users can now authenticate using GitHub App installation credentials instead of personal tokens.
Key Changes
github_app_id,github_app_installation_id, andgithub_app_private_keybradleyfalzon/ghinstallationlibrarygoogle/go-githubfrom v28 to v75bradleyfalzon/ghinstallation/v2for GitHub App JWT authenticationgo.modto Go 1.24.0Backward Compatibility
Testing