This repository was archived by the owner on Feb 10, 2022. It is now read-only.
Add logrotate property for containers#153
Open
Nibooor wants to merge 1 commit intocloudfoundry-incubator:mainfrom
Open
Add logrotate property for containers#153Nibooor wants to merge 1 commit intocloudfoundry-incubator:mainfrom
Nibooor wants to merge 1 commit intocloudfoundry-incubator:mainfrom
Conversation
Standard docker container logs are only available for as long as the container is running, since a monit stop also removes the container (including logs) using docker rm. To properly persist logs even after a container is stopped or restarted it seems that you have to write your own application logs and bind-mount the log directory to a persistent disk. However, logs are not rotated this way. To avoid the necessity of doing manual configurations to the bosh release or on a VM, make custom logrotation settings possible via a container property.
|
|
|
Stale pull request message |
|
@neil-hickey Any chance somebody could do a code review for this change? I see you recently merged some PRs, maybe you can help to identify somebody to look into this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standard docker container logs are only available for as long as
the container is running, since a monit stop also removes the
container (including logs) using docker rm.
To properly persist logs even after a container is stopped or
restarted it seems that you have to write your own application logs
and bind-mount the log directory to a persistent disk.
However, logs are not rotated this way.
To avoid the necessity of doing manual configurations to the bosh
release or on a VM, make custom logrotation settings possible via
a container property.