Skip to content

Rename dea_next staging params to cc section#658

Open
WeiQuan0605 wants to merge 1 commit into
cloudfoundry:developfrom
sap-contributions:main
Open

Rename dea_next staging params to cc section#658
WeiQuan0605 wants to merge 1 commit into
cloudfoundry:developfrom
sap-contributions:main

Conversation

@WeiQuan0605

Copy link
Copy Markdown
Contributor

Replace historic dea_next.staging_memory_limit_mb and dea_next.staging_disk_limit_mb with cc.minimum_staging_memory_mb and cc.minimum_staging_disk_mb to better reflect their semantics as minimum (not limit) values. Remove unused dea_next.advertise_interval_in_seconds.

Thanks for contributing to the capi_release. To speed up the process of reviewing your pull request please provide us with:

  • A short explanation of the proposed change:
    Rename dea_next staging params to cc section. Remove unused dea_next.advertise_interval_in_seconds.

    Replace historic dea_next.staging_memory_limit_mb and dea_next.staging_disk_limit_mb
    with cc.minimum_staging_memory_mb and cc.minimum_staging_disk_mb

  • An explanation of the use cases your change solves
    New parameter better reflect their semantics as minimum values.

  • Links to any other associated PRs

  • I have viewed signed and have submitted the Contributor License Agreement

  • I have made this pull request to the develop branch

  • I have run CF Acceptance Tests on bosh lite

Replace historic dea_next.staging_memory_limit_mb and dea_next.staging_disk_limit_mb
with cc.minimum_staging_memory_mb and cc.minimum_staging_disk_mb to better reflect
their semantics as minimum (not limit) values. Remove unused dea_next.advertise_interval_in_seconds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants