fakeclock: rewrite tests with stdlib#91
Open
thaJeztah wants to merge 1 commit into
Open
Conversation
|
|
cf-foundation-community-automation
Bot
moved this to Inbox
in Application Runtime Platform Working Group
Author
|
cc @geofffranks, @vito Could use some extra eyes on this; tests passed locally, but looks like no tests are running in CI here, as the GitHub workflows were removed in 4e3404c 🤔 |
1 task
thaJeztah
force-pushed
the
stdlib_testing
branch
from
3cb27fe to
d7eeff7
Compare
1 task
The code in this repository hasn't changed in the last 8 Years, but tests were using the GinkGo testing framework, which added many dependencies, and causing code-churn due to automation to keep those dependencies up-to-date. This patch attempts to replace GinkGo with the stdlib testing package, removing all dependencies. Disclaimer: the rewrite was assisted with CoPilot. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
stdlib_testing
branch
from
d7eeff7 to
f59ddf2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code in this repository hasn't changed in the last 8 Years, but tests were using the GinkGo testing framework, which added many dependencies, and causing code-churn due to automation to keep those dependencies up-to-date.
This patch attempts to replace GinkGo with the stdlib testing package, removing all dependencies.
Disclaimer: the rewrite was assisted with CoPilot.
Summary
Backward Compatibility
Breaking Change? Yes/No