Force delete very old delayed jobs#4395
Merged
Merged
Conversation
svkrieger
force-pushed
the
force-delete-very-old-delayed-jobs
branch
from
256e517 to
f985f7c
Compare
svkrieger
force-pushed
the
force-delete-very-old-delayed-jobs
branch
from
f985f7c to
9a9248f
Compare
philippthun
reviewed
Jun 12, 2025
We found some old jobs in the delayed_jobs table, which are beyond the cutoff_age_in_days interval. They had either no failed_at set or were still locked. With this change the FailedJobsCleanup job will force delete all jobs, which are older than the cutoff_age_in_days + 1 day.
svkrieger
force-pushed
the
force-delete-very-old-delayed-jobs
branch
from
9a9248f to
c4bca63
Compare
philippthun
approved these changes
Jun 12, 2025
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Jun 12, 2025
Changes in cloud_controller_ng:
- Force delete very old delayed jobs
PR: cloudfoundry/cloud_controller_ng#4395
Author: Sven Krieger <37476281+svkrieger@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A short explanation of the proposed change:
Force delete delayed_jobs, which are older (run_at) then the configured cutoff_age_in_days + 1 day.
An explanation of the use cases your change solves
We found some old jobs in the delayed_jobs table, which are beyond the cutoff_age_in_days interval. They had either no failed_at set or were still locked. With this change the FailedJobsCleanup job will force delete all jobs, which are older than the cutoff_age_in_days + 1 day.
Links to any other associated PRs
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests