Add ADR 0015: switch to factory_bot; supersede ADR 0002#5120
Merged
Conversation
Member
Author
|
Actual migration in #5121. |
sethboyles
previously approved these changes
Jun 9, 2026
johha
reviewed
Jun 10, 2026
| factory definitions under `spec/support/factory_definitions/`. | ||
|
|
||
| The conversion is done as one change. There is no extended period in which | ||
| both libraries coexist in the codebase. |
Contributor
There was a problem hiding this comment.
Maybe it should be briefly mentioned why we do a big bang migration and not an incremental one.
Member
Author
There was a problem hiding this comment.
I've removed that sentence. The ADR should document the goal / the desired end state - if done incrementally or as a big bang migration is an independent decision.
ADR 0002 (2019) chose to keep machinist after a partial factory_bot migration hit friction with Sequel's mutual-foreign-key pattern. The blocker described there is solvable in factory_bot using a global to_create with save+refresh and after(:create) callbacks with transient flags. machinist 1.0.6 has had no upstream activity since 2013, and 2.0 is not a viable upgrade (no Sequel adapter, no Sham, non-persisting make). Mark ADR 0002 as superseded and add ADR 0015 documenting the new decision and the patterns that made it work.
philippthun
force-pushed
the
adr-factory-bot
branch
from
7fadd04 to
c503307
Compare
johha
approved these changes
Jun 11, 2026
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Jun 11, 2026
Changes in cloud_controller_ng:
- Add ADR 0015: switch to factory_bot; supersede ADR 0002
PR: cloudfoundry/cloud_controller_ng#5120
Author: Philipp Thun <philipp.thun@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADR 0002 (2019) chose to keep
machinistafter a partialfactory_botmigration hit friction with Sequel's mutual-foreign-key pattern.The blocker described there is solvable in
factory_botusing a globalto_createwithsave+refreshandafter(:create)callbacks with transient flags. machinist 1.0.6 has had no upstream activity since 2013, and 2.0 is not a viable upgrade (no Sequel adapter, no Sham, non-persisting make).Mark ADR 0002 as superseded and add ADR 0015 documenting the new decision and the patterns that made it work.
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests