Conversation
We can do this because: * golanci-lint already uses go vet internally * ginkgo command does what `go test -race` did and more
jorbaum
force-pushed
the
use-new-test-scripts
branch
from
59c06e7 to
e2f79b7
Compare
cf-foundation-community-automation
bot
moved this to Inbox
in Application Runtime Platform Working Group
chombium
left a comment
chombium
left a comment
There was a problem hiding this comment.
LGTM apart from a small objection, to have everything in sync with the other projects.
| if [ "${CI:-false}" = 'false' ]; then | ||
| flags="${flags} -p" | ||
| fi | ||
| pushd "${SCRIPT_DIR}/../.." > /dev/null |
There was a problem hiding this comment.
Run Ginkgo directly as in the other projects like for example in loggregator-agent-release:
go run github.com/onsi/ginkgo/v2/ginkgo $flags
There was a problem hiding this comment.
Can you elaborate why?
My idea was to fix this in loggregator-agent-release as well with PR cloudfoundry/loggregator-agent-release#717 . There I state:
Harmonize with lint script
This avoids recompiling ginkgo every time
chombium
left a comment
chombium
left a comment
There was a problem hiding this comment.
We can keep the script like this, but we have to change the other project where ginkgo is run.
github-project-automation
bot
moved this from Inbox
to Pending Merge | Prioritized
in Application Runtime Platform Working Group
github-project-automation
bot
moved this from Pending Merge | Prioritized
to Done
in Application Runtime Platform Working Group
I created similar PRs in other projects: |
2 participants
Add test scripts and use them in GH actions. Replaces
go runwithginkgoandgo vetwithgolangci-lint.Does more or less the same as cloudfoundry/loggregator-release@612b9ad with enhancements in cloudfoundry/loggregator-agent-release#717